Fixes #962
Open
Fixes #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macbre
reviewed
Mar 21, 2025
| css: '.foo { border-color: #000 #000000 rgb(0,0,0) rgba(0,0,0,1) }', | ||
| metrics: { | ||
| colors: 2 | ||
| colors: 1 |
|
@christophe-ledu - sorry for an extremely late reply here :-( Can you please rebase this PR against the latest upstream changes? Alternatively, I can try cherry-picking your changes. |
auto-merge was automatically disabled
April 18, 2025 08:51
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a failing test too, I guess the color parsing now detect the 4 black colors as the same color
It's possible to change
csslib with@adobe/css-tools, better maintained thencss