Skip to content

Conversation

alexs-mparticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • {provide a thorough description of the changes}

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up code style and lint issues across the codebase. Key changes include adding trailing commas where needed, replacing var with const/let, and minor formatting improvements to improve consistency.

Reviewed Changes

Copilot reviewed 92 out of 92 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/identity.interfaces.ts Added trailing commas for parameter consistency
src/identity-utils.ts Added trailing commas in function parameters
src/helpers.js Converted var declarations to let/const and added trailing commas
src/forwardingStatsUploader.js Replaced var with const for improved consistency
src/forwarders.js Updated variable bindings and formatting for clarity
src/forwarders.interfaces.ts Enforced trailing commas in type definitions
src/foregroundTimeTracker.ts Removed extraneous blank lines and standardized event listener callbacks
src/filteredMparticleUser.js Replaced var with const and updated for... loop declarations
src/events.js Updated arrow functions and trailing commas for consistency
src/events.interfaces.ts Added trailing commas in interface definitions
src/ecommerce.js Added trailing commas in logger messages
src/ecommerce.interfaces.ts Added missing commas in function parameters
src/cookieSyncManager.ts Simplified import formatting and trailing comma fixes
src/consent.ts Cleaned up trailing commas and formatted logger messages
src/configAPIClient.ts Added trailing commas in function parameters and logger messages
src/batchUploader.ts Updated variable declarations and formatting; added missing commas
src/audienceManager.ts Reformatted constructor parameters and error messages
src/audience.ts Simplified constructor syntax
src/apiClient.ts Standardized function parameters and trailing commas in logger messages
package.json Added a new lint:fix script
Comments suppressed due to low confidence (1)

src/batchUploader.ts:329

  • The string 'Skiping' appears to be misspelled. Please change it to 'Skipping' for clarity.
mpInstance.Logger.warning('Skiping batch upload because no batch was returned from onCreateBatch callback')

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
20.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant