Fix: Convert StringRef to const char* in wake word engine checks for HA 2026.1#28
Closed
simoozzay wants to merge 1 commit intom5stack:mainfrom
Closed
Fix: Convert StringRef to const char* in wake word engine checks for HA 2026.1#28simoozzay wants to merge 1 commit intom5stack:mainfrom
simoozzay wants to merge 1 commit intom5stack:mainfrom
Conversation
Contributor
|
Hi, thanks for the PR. The has been fixed in 7212bc8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Convert StringRef to const char* in wake word engine checks
Description
This PR fixes a type conversion issue in the
atoms3r-with-echo-base.yamlconfiguration file wherecurrent_option()returns aStringRefobject that needs to be converted toconst char*using.c_str()before comparison with string literals.Problem
The lambda functions were attempting to directly assign the result of
current_option()to aconst char*pointer without proper conversion, which could cause compilation issues or runtime errors depending on the ESPHome version.Solution
Added
.c_str()method calls to all wake word engine location checks to properly convert theStringRefreturn value to a C-style string pointer.Changes
common/atoms3r-with-echo-base.yamlto use.c_str()for proper type conversionFiles Changed
common/atoms3r-with-echo-base.yaml