Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT] Implement IIRWriter API #1228

Merged
merged 16 commits into from
Aug 29, 2024
Merged

[NativeAOT] Implement IIRWriter API #1228

merged 16 commits into from
Aug 29, 2024

Conversation

IsaMorphic
Copy link
Contributor

Based on the research and precedent consisting of #1225 and #1214, I am starting from scratch to implement a bitstream writer for the IR graph.

@IsaMorphic IsaMorphic marked this pull request as ready for review May 24, 2024 15:54
@IsaMorphic IsaMorphic changed the title [NativeAOT] Implement IRWriter class [NativeAOT] Implement IIRWriter class May 24, 2024
@IsaMorphic IsaMorphic changed the title [NativeAOT] Implement IIRWriter class [NativeAOT] Implement IIRWriter API May 24, 2024
@IsaMorphic IsaMorphic mentioned this pull request May 25, 2024
Draft
@IsaMorphic IsaMorphic force-pushed the feature/ir-serializer branch 2 times, most recently from 6799068 to 33b948f Compare May 31, 2024 13:47
m4rs-mt
m4rs-mt requested changes Jun 4, 2024
View reviewed changes
Src/ILGPU/IR/Types/TypeNode.cs Outdated Show resolved Hide resolved
Src/ILGPU/IR/Types/IRTypeContext.cs Outdated Show resolved Hide resolved
Src/ILGPU/IR/Values/Compare.cs Outdated Show resolved Hide resolved
Src/ILGPU/IR/Serialization/BinaryIRWriter.cs Outdated Show resolved Hide resolved
@IsaMorphic
Copy link
Contributor Author

@m4rs-mt Do we want to write tests for the new API?

@IsaMorphic IsaMorphic requested a review from m4rs-mt June 4, 2024 15:56
m4rs-mt
m4rs-mt requested changes Jul 18, 2024
View reviewed changes
Copy link
Owner

@m4rs-mt m4rs-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few minor things to address and this PR is ready to go 🚀

Src/ILGPU/IR/IRContext.cs Outdated Show resolved Hide resolved
Src/ILGPU/IR/IRContext.cs Outdated Show resolved Hide resolved
Src/ILGPU/IR/Types/IIRTypeContext.cs Outdated Show resolved Hide resolved
Src/ILGPU/IR/Types/StructureType.cs Outdated Show resolved Hide resolved
Src/ILGPU/IR/Values/PhiValue.cs Outdated Show resolved Hide resolved
Src/ILGPU/IR/Values/Terminators.cs Outdated Show resolved Hide resolved
@IsaMorphic IsaMorphic requested a review from m4rs-mt July 19, 2024 14:09
@IsaMorphic IsaMorphic force-pushed the feature/ir-serializer branch 2 times, most recently from 6ff8f18 to 11a7434 Compare July 19, 2024 14:15
@IsaMorphic
Copy link
Contributor Author

@m4rs-mt Just fixed the code styles stuff! Super excited to have my first contribution merged :)

@m4rs-mt m4rs-mt force-pushed the feature/ir-serializer branch from 745104b to 0d578ef Compare August 27, 2024 06:28
@m4rs-mt m4rs-mt added this to the v2.0 milestone Aug 27, 2024
@m4rs-mt m4rs-mt added the feature A new feature (or feature request) label Aug 27, 2024
@m4rs-mt m4rs-mt merged commit 1dff15e into m4rs-mt:master Aug 29, 2024
51 checks passed
@IsaMorphic IsaMorphic deleted the feature/ir-serializer branch September 1, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4rs-mt m4rs-mt m4rs-mt approved these changes

Assignees
No one assigned
Labels
feature A new feature (or feature request)
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@IsaMorphic @m4rs-mt