Updated NVVM to support Cuda SDK v8. #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4rs-mt
approved these changes
Apr 9, 2024
MoFtZ
added a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 18, 2024
# Conflicts: # Src/ILGPU/Context.Builder.cs
MoFtZ
added a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 18, 2024
# Conflicts: # Src/ILGPU/Context.Builder.cs
MoFtZ
added a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1148.
When LibDevice support was added in #707, it was targeting Cuda SDK v11.
In Cuda SDK v8, there is a conflict in searching for
nvvm*.dllbecause the folder containsnvvm64_31_0.dllandnvvm32_31_0.dll. Updated to usenvvm64*.dll, since we only support 64-bit Cuda in ILGPU.In addition, Cuda SDK v8 does not have an implementation of
nvvmLazyAddModuleToProgram- this was added in v9. Added a fallback to use the older, non-lazynvvmAddModuleToProgram.