Optimized PTX IntrinsicMath implementation to use LibDevice. #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoFtZ
force-pushed
the
feature/intrinsic-math
branch
from
37af1f7 to
7f5b781
Compare
MoFtZ
force-pushed
the
feature/intrinsic-math
branch
2 times, most recently
from
12de7ec to
38184e8
Compare
MoFtZ
force-pushed
the
feature/intrinsic-math
branch
from
38184e8 to
bb287e9
Compare
MoFtZ
force-pushed
the
feature/intrinsic-math
branch
from
bb287e9 to
c3a1db2
Compare
MoFtZ
force-pushed
the
feature/intrinsic-math
branch
from
dc44edc to
1f16948
Compare
MoFtZ
force-pushed
the
feature/intrinsic-math
branch
from
1f16948 to
e87d746
Compare
|
Abandoned. To be combined with #1148. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1148.
Restructured ILGPU and ILGPU.Algorithms, moving the
IntrinsicMathimplementations into ILGPU itself.XMathhas other functions that are not part ofIntrisicMath, so it will stay as-is for now.CLMathin ILGPU.Algorithms only needed to supportRcpandLog(x,y). These have been moved into ILGPU, andCLMathhas been removed.PTXMathin ILGPU.Algorithms provided a number of math functions using Cordic implemenentations. Now that pre-generated LibDevice is available in ILGPU, switched all the IntrinsicMath functions to call LibDevice for Cuda GPUs. The pre-generated LibDevice PTX code only works on>= SM_60, so the Cordic functions in ILGPU.Algorithms have been modified to only register for< SM_60. Otherwise, they are no longer used.Unit Tests for
IntrinsicMathhave not been implemented. These are currently running via the ILGPU.Algorithms unit tests.