Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKV container option #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MKV container option #88

wants to merge 1 commit into from

Conversation

hcook95
Copy link

@hcook95 hcook95 commented Jun 23, 2024

Added an option to add soft subs to the video in a .mkv container.

Copy link

what-the-diff bot commented Jun 23, 2024

PR Summary

  • Introduction of a New Parameter in Command Line Interface
    This upgrade introduces a new element named output_mkv in the command-line interface (CLI). This feature will give users the ability to save the subtitled video in their desired format, either an .mkv or .mp4 container. By default, the subtitled video will be in .mp4 format.

  • Adjustments to Enhance output_mkv Functionality
    Specific conditional statements have been incorporated. These improvements guide the software on how to respond when output_mkv is set to True. In this case, it leverages on the ffmpeg.output instead of ffmpeg.concat method. Its objective is to enable smooth transfer of video and subtitle streams into an .mkv container.

  • Flexible Output File Extension
    The output file extension has been modified for flexibility. With this, the output video can switch between "mkv" or "mp4" formats effortlessly. This is determined by the user's preference, specifically the value set for output_mkv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant