Add on_progress callback for transcribe and align #620
+43
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional `on_progress` argument to both the `align` and `transcribe` methods.
This allows processing the current progress via a callback, until now, it was only possible to print the progress to `STDOUT`.
Example:
```python
transcribe(
my_audio,
batch_size=8,
on_progress=lambda state, current=0, total=0: print(f"state: {state}, current: {current}, t: {total}")
)
```
States are defined as
```python
class TranscriptionState(Enum):
LOADING_AUDIO = "loading_audio"
GENERATING_VAD_SEGMENTS = "generating_vad_segments"
TRANSCRIBING = "transcribing"
FINISHED = "finished"
```
Signed-off-by: Stefan Exner <[email protected]>
|
nice work, great feature. keep going |
|
this feature is exactly what we need at the moment |
|
@matheusbach @IgorTavcar is there something missing in this PR that you'd need for your work? |
|
this would be very useful if merged! |
|
Progress in transcribe already works, and works well. Aligning not works
well
На вт, 5.03.2024 г. в 22:38 pluja ***@***.***> написа:
… this would be very useful if merged!
—
Reply to this email directly, view it on GitHub
<#620 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYTSUPVNY7DVUORLE5K3PLYWYUN7AVCNFSM6AAAAABAOC7PN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZGU4TONBTHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@casic what doesn't work regarding alignment? |
|
align progress function , first show fast progress to 100% , then
start real work.
На ср, 13.03.2024 г. в 16:36 Stefan Exner ***@***.***> написа:
… @casic <https://github.com/casic> what doesn't work regarding alignment?
—
Reply to this email directly, view it on GitHub
<#620 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYTSUJCYEQW56JEBTKH5FLYYBP5VAVCNFSM6AAAAABAOC7PN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGU2DONJRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I appreciate if it the function parameter was padronized between transcribe and align step. Also, the enumerated status used in transcribe step is very useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional
on_progressargument to both thealignandtranscribemethods.This allows processing the current progress via a callback, until now, it was only possible to print the progress to
STDOUT.Example:
States are defined as