Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace of the "fence" changes from PR #550 #552

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evaleev
Copy link
Contributor

@evaleev evaleev commented Oct 11, 2024

#550 (namely, 6ab4484) introduced change in fence semantics that ensure that:

  • local # of tasks is zero after reading AM counts
  • repeat global termdet after epilogue/cleanup

this caused hangs in various parts of TiledArray when running in Github Action Runners (but not elsewhere). 93a9a5c reverted it. This PR contains these changes for reconsideration.

for this we ensure that:
- local # of tasks is zero after reading AM counts
- repeat global termdet after epilogue/cleanup

(cherry picked from commit 6ab4484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant