Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: adding k8s probes #2687

Merged
merged 27 commits into from
Jun 14, 2023
Merged

api: adding k8s probes #2687

merged 27 commits into from
Jun 14, 2023

Conversation

fran2344
Copy link
Contributor

@fran2344 fran2344 commented Jun 9, 2023

Description

Adding a new feature that update Liveness Probes and Readness probes in k8s cluster deployments.

Updating attributes in deployment
Screenshot 2023-06-09 at 13 50 59

Response if everything goes well
Screenshot 2023-06-09 at 13 51 14

Testing Performed

You could try with the frontend or pointing directly to the backend

curl -X POST http://localhost:8080/v1/k8s/updateDeployment
-H 'Content-Type: application/json' 
--data 
'{"clientset": "clientset", 
"cluster": "mycluster",
"namespace": "default", 
"name": "two-container-app", 
"fields": 
{ 
"containerProbes": 
[
{"containerName": "container2", 
"readinessProbe": 
  {"initialDelaySeconds": "6", "periodSeconds": "4" }
}]}}'

@fran2344 fran2344 requested a review from a team as a code owner June 9, 2023 19:55
@mikecutalo
Copy link
Contributor

Hey @fran2344 thanks for the contribution! I think what I'm going to ask you to do is break up this PR into 3 different parts so the diff's are smaller and easier to review. Lets do an individual PR for, 1) The Proto changes, 2) the backend, 3) the frontend.

Breaking it up will be easier for the team to review and will be able to get the changes in faster.

@fran2344
Copy link
Contributor Author

Hi @mikecutalo I update and remove the references in backend and frontend please let me know if its ok

backend/go.mod Outdated Show resolved Hide resolved
api/k8s/v1/k8s.proto Outdated Show resolved Hide resolved
@mikecutalo mikecutalo changed the title Adding updating probes feature front/backend api: adding k8s probes Jun 12, 2023
backend/go.sum Outdated Show resolved Hide resolved
api/k8s/v1/k8s.proto Outdated Show resolved Hide resolved
api/k8s/v1/k8s.proto Show resolved Hide resolved
api/k8s/v1/k8s.proto Show resolved Hide resolved
api/k8s/v1/k8s.proto Show resolved Hide resolved
fran2344 and others added 21 commits June 13, 2023 15:33
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| golang | stage | minor | `1.19.5-buster` -> `1.20.5-buster` |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/lyft/clutch).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mikecutalo mikecutalo merged commit 7c4750d into lyft:main Jun 14, 2023
11 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants