-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DEVCON-7212: Upgrade atlantis to Go 1.23 (#770)
Time to upgrade to Go 1.23 I had to update a few function calls with new lint checks for go vet, similar to how it was done in runatlantis/atlantis@37580ba Also had to ignore `gosec` linter in a few instances because it wanted us to use `0600` instead and that made all the tests fail and when we inspected with an IDE it showed the dirs not available with those
- Loading branch information
1 parent
85c9409
commit 5368355
Showing
11 changed files
with
22 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,10 @@ jobs: | |
steps: | ||
- uses: actions/setup-go@v3 | ||
with: | ||
go-version: 1.22 | ||
go-version: 1.23 | ||
- uses: actions/checkout@v3 | ||
- name: Run golangci-lint | ||
uses: golangci/[email protected] | ||
with: | ||
args: --timeout 3m --verbose --disable revive | ||
version: v1.56.2 | ||
version: v1.60.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -113,7 +113,7 @@ func TestRefresh(t *testing.T) { | |
credentialsFile := filepath.Join(dir, ".git-credentials") | ||
oldContents := "https://x-access-token:[email protected]" | ||
|
||
err := os.WriteFile(credentialsFile, []byte(oldContents), os.ModePerm) | ||
err := os.WriteFile(credentialsFile, []byte(oldContents), os.ModePerm) //nolint:gosec | ||
assert.NoError(t, err) | ||
|
||
capturedGitArgs := [][]string{} | ||
|
@@ -159,7 +159,7 @@ func TestRefresh(t *testing.T) { | |
credentialsFile := filepath.Join(dir, ".git-credentials") | ||
oldContents := "https://x-access-token:[email protected]" | ||
|
||
err := os.WriteFile(credentialsFile, []byte(oldContents), os.ModePerm) | ||
err := os.WriteFile(credentialsFile, []byte(oldContents), os.ModePerm) //nolint:gosec | ||
assert.NoError(t, err) | ||
|
||
tc := &testInstallationTransport{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters