Remove support for scrollable elements

Firefox has sadly removed support for the `overflow` and `underflow` events which powered this feature: https://bugzilla.mozilla.org/show_bug.cgi?id=1888737 I don't know of any other way to implement it, so I removed it.
lydell · Aug 17, 2024 · 5a56c88 · 5a56c88
1 parent 6fa26b1
commit 5a56c88
Show file tree

Hide file tree

Showing 10 changed files with 10 additions and 286 deletions.
diff --git a/docs/index.tsx b/docs/index.tsx
@@ -133,7 +133,6 @@ const SECTIONS = [
             .
           </li>
           <li>Tracking of elements with click listeners.</li>
-          <li>Tracking of scrollable elements in Firefox.</li>
           <li>Tracking elements and updating hints while showing them.</li>
           <li>Text based hint positioning.</li>
           <li>

diff --git a/html/experiments/intersection-observer-cover.html b/html/experiments/intersection-observer-cover.html
@@ -61,7 +61,6 @@
       observer.observe(cover);
 
       window.addEventListener("resize", updateCover);
-      window.addEventListener("underflow", updateCover);
 
       function updateCover() {
         const viewport = getViewport();

diff --git a/html/hint-position/index.html b/html/hint-position/index.html
@@ -479,17 +479,6 @@
         margin: 0;
         padding-bottom: 50px;
       }
-
-      .scroll {
-        border: 1px solid black;
-        overflow: auto;
-        height: 100px;
-        width: 200px;
-      }
-
-      .scroll > p {
-        margin-bottom: 200px;
-      }
     </style>
   </head>
   <body>
@@ -1065,12 +1054,6 @@ <h2>Images taller than their link</h2>
       </a>
     </p>
 
-    <h2>Scrollable element</h2>
-    <p>The hint should be placed at the edge, not at children text.</p>
-    <div class="scroll">
-      <p>Scrollable element</p>
-    </div>
-
     <h2>Selectable elements</h2>
     <div style="max-width: 500px">
       <p>

diff --git a/html/scroll/index.html b/html/scroll/index.html
diff --git a/html/untrusted-events/index.html b/html/untrusted-events/index.html
@@ -77,7 +77,6 @@
               "clickable-event",
               "label",
               "link",
-              "scrollable",
               "textarea",
             ],
             viewports: [

diff --git a/src/background/Program.ts b/src/background/Program.ts
@@ -2369,7 +2369,6 @@ const CLICK_TYPES: ElementTypes = [
   "clickable-event",
   "label",
   "link",
-  "scrollable",
   "textarea",
 ];
 

diff --git a/src/renderer/Program.ts b/src/renderer/Program.ts
@@ -431,12 +431,6 @@ export default class RendererProgram {
         "resize",
         this.onResize.bind(this),
         "RendererProgram#onResize"
-      ),
-      addEventListener(
-        window,
-        "underflow",
-        this.onResize.bind(this),
-        "RendererProgram#onResize"
       )
     );
 

diff --git a/src/shared/hints.ts b/src/shared/hints.ts
@@ -6,7 +6,6 @@ export const ElementType = stringUnion({
   clickable: null,
   label: null,
   link: null,
-  scrollable: null,
   selectable: null,
   textarea: null,
 });