Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxqt-config-brightness: Set minimum backlight #858

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

selairi
Copy link
Contributor

@selairi selairi commented May 16, 2022

In some hardware the 5% as minimum value of backlight can be too brightness. Advanced options has been added to select this minimum value:

2022-05-16 19;25;17

<item>
<widget class="QGroupBox" name="groupBox_3">
<property name="toolTip">
<string>The minimum value for backlight value can be really brightness.
Copy link
Member

@tsujan tsujan May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence needs to be corrected. Did you mean, "The minimum value of backlight can be too high"?

<property name="toolTip">
<string>The minimum value for backlight value can be really brightness.
It is possible set this minimum value.
Warning: If a very low backlight is set, a black screen can be shown.</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the first sentence isn't needed, and this tooltip can be changed to something like:

The minimum value of backlight.
Warning: A very low value can result in a black screen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Fixed.


ui->backlightSlider->setMaximum(maxBacklight);
ui->backlightSlider->setMinimum(minBacklight);
ui->backlightSlider->setValue(value);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A newline is missing here.

@tsujan
Copy link
Member

tsujan commented May 17, 2022

IMHO, the code needs to take care of the minimum value automatically. The new GUI seems too confusing to me.

Do other DEs do this?

@selairi
Copy link
Contributor Author

selairi commented May 17, 2022

Do other DEs do this?

No. Other DEs doesn't set a minimum value for the backlight. For example, I have downloaded the code of XFCE and I have checked the minimum value for the backlight and it is set to 0.
I have found that other DEs let set the number of steps of backlight and the change of the backlight is usually done by keyboard.
LXQt should add those shortcuts to lxqt-panel brightness plugin.
Then lxqt-config-brightness should let you set the number of steps of backlight, the gamma (for desktop computers) and backlight. I think that an option for launch and config gammastep should be added also.

Thanks for your hard work.

@tsujan
Copy link
Member

tsujan commented May 17, 2022

LXQt should add those shortcuts to lxqt-panel brightness plugin.

Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants