Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add option to scale widgets to double size #571

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jdoxey
Copy link

@jdoxey jdoxey commented Nov 30, 2019

Selecting this option is a shortcut which adds/sets the following environment variables (under Session Settings > Environment (Advanced)),

Selecting this option is a shortcut which adds/sets the following environment variables (under Session Settings > Environment (Advanced)),
- QT_SCALE_FACTOR=2
- QT_AUTO_SCREEN_SCALE_FACTOR=0 (to stop HiDPI Qt apps like Qt Designer from scaling twice)
- GDK_SCALE=2
- XCURSOR_SIZE=32
as described in this thread https://forum.lxqt.org/t/detailed-guide-to-enable-high-dpi-scaling-on-lxqt/507
@tsujan tsujan requested a review from selairi December 2, 2019 11:54
@tsujan
Copy link
Member

tsujan commented Dec 2, 2019

This is a nice idea that needs more work.

IMHO, there are 4 problems with this approach. From important to small:

  1. There are four EVs but only one option: to be or not to be.
  2. The values -- especially that of QT_SCALE_FACTOR -- aren't chosen by the user. Appropriate spin-boxes/combo-boxes are missing.
  3. Widget style is not the right place because this isn't about styling. (All other items are about styling.)
  4. In the explanation, it's supposed that Openbox is LXQt's WM.

@jdoxey
Copy link
Author

jdoxey commented Dec 3, 2019

Regarding points 1 and 2: Yes, maybe the values should be editable on the same screen, without having to go to Session Settings > Environment.
Regarding point 3: Where do you think an option like this should live? (Eventually it would be nice in the Monitor settings, so you can set it separately for each screen, but that feature will probably present a new set of challenges)

@tsujan
Copy link
Member

tsujan commented Dec 3, 2019

Where do you think an option like this should live?

XCURSOR_SIZE can go to the Cursor section of LXQt Appearance Configuration, with an appropriate setting of its own. The other three EVs can have a separate "Scaling" section -- again, with appropriate settings, like spin/combo boxes.

That was only a suggestion. I like to know what other devs think, especially @selairi, who's the expert in this area.

But I like the idea and think that it should be implemented.

@agaida agaida changed the title Add option to scale widgets to double size WIP: Add option to scale widgets to double size Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants