Skip to content

Cleanup -d screenshot filename generation #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

isf63
Copy link
Contributor

@isf63 isf63 commented May 18, 2025

  -d, --dirscreenshot <DIR>  Take a screenshot and save it to the directory
                             without showing the GUI (deprecated, please use
                             screengrab instead)

Previously the filenames were incomprehensible without knowledge of the code.

This also simplifies things.

@isf63 isf63 requested a review from tsujan May 18, 2025 19:53
@tsujan
Copy link
Member

tsujan commented May 20, 2025

Previously the filenames were incomprehensible

They weren't supposed to. The goal was explained in the code clearly.

I don't see a reason for a change.

@isf63
Copy link
Contributor Author

isf63 commented May 21, 2025

If anything this PR is about simplification - the filename is sane, and the code is cleaner/simpler

@tsujan
Copy link
Member

tsujan commented May 21, 2025

… is about simplification

Too subjective. We have a clean static function that does the job for us and includes the pid too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants