Update configuration for examples/api_test.py #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example script is guaranteed to fail on modern Ubuntu releases due to outdated configuration. These changes allow the script to pass:
- Fixes container.create arguments to request Noble image instead of Xenial, as Xenial images are no longer available
- Changes cgroups key strings to use cgroups v2 nomenclature ('max' instead of 'limit_in_bytes', 'peak' instead of 'max_usage_in_bytes')
Signed-off-by: Austin Rhodes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example script is guaranteed to fail on modern Ubuntu releases due to outdated configuration. These changes allow the script to pass on at least Noble:
Fixes container.create arguments to request Noble image instead of Xenial, as Xenial images are no longer available
Changes cgroups key strings to use cgroups v2 nomenclature (
maxinstead oflimit_in_bytes,peakinstead ofmax_usage_in_bytes)The Xenial image issue manifests as:
The cgroups issue (which, admittedly, will only occur on systems running cgroups v2) will manifest as
KeyError: invalid cgroup entry. I propose this change simply because cgroups v2 is default on modern Ubuntu releases.