Skip to content

Conversation

c24-tj
Copy link

@c24-tj c24-tj commented Oct 2, 2025

This PR implements #2484

@c24-tj c24-tj requested a review from stgraber as a code owner October 2, 2025 17:40
@stgraber
Copy link
Member

stgraber commented Oct 3, 2025

Logic for setting and handling of the new config key looks good but I think this is missing logic to actually have the instances write their logs to that path.

Most systems run with the default of using /var/log/incus/ so having a path now ready at /var/lib/incus/logs/ with the pre-existing data moved there will not cause new instances from logging at the new location.

Also another small wrinkle, running instances will not like their existing log files being moved across mounts, that will effectively break logging for those. So we should add a check so the config key can only be changed if the system has no running instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants