Add instructions for getting the test setup to run #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mkbrechtel that looks good but your commits don't have the Signed-off-by line (see CONTRIBUTING.md). |
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Thank you, i missed that, i signed off my commits and rebased to your recent changes. |
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
stgraber
approved these changes
Apr 12, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some documentation on how to get it to run in the current state.
It depends on pull request #3 for this to run through without errors.