-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: per-section previousWindowShortcut bindings #2311
feat: per-section previousWindowShortcut bindings #2311
Conversation
feat: some tweaks fix: other shortcut section's back shortcut would invoke back fix: passing proper index refactor: removed old code and renamed feat: added comment feat: added preference migration for previousWindowShortcut feat: renamed label fix: unused variable feat: added a bit of whitespace
Hi @chase-miller, Thank you for sharing your work in this PR. I'm afraid that, as indicated in the ticket's discussion, I don't think it's a positive for most users to move this action in a per-shortcut mode. I'm afraid I won't be able to merge this PR 🙇 |
@lwouis is there some way we can test our hypotheses? Maybe add a checkbox next to the global previous binding field that enables per-shortcut bindings? We could then passively track usage of the new fields (maybe a feedback button), or we could simply see if there's a reduction in previous window-related issues on GitHub. Or something else :-) I hypothesize that it will actually be less confusing to pair previous bindings alongside forward bindings. It will also facilitate the idiomatic Here’s an example of Witch’s preference pane as an example of a similar app that does it this way: What do you think about somehow testing this out to see how users react? P.S. In case others find it useful I’ll aim to maintain a fork at https://github.com/chase-miller/alt-tab-macos that adds this feature. |
We don't do telemetry and never will. This leaves us with only 1 source of user feedback: github tickets. Either from people visiting github directly, or people using the in-app "Send feedback..." form, which automatically creates a new github ticket. I've been working on this app for 3 years. I've been responding, classifying, discussing tickets alone during that time. I've never found someone who would be interested to co-pilot this project (neither has anyone shown serious interest for #1179). Throughout that time, I've observed the type of users this software has. It's a biased sample of the total userbase, which I estimate at around 100K people. But it's the only data I have, beyond my own desires/vision for the product. Overall, I think a handful of people, at most, have asked for this. There are more people, for instance, who are asking to have the backward-cycling shortcut be triggerable when AltTab is not open (i.e. "I want to summon AltTab by pressing option+shift+tab"). They expect it from Windows. Both are quite niche, as defined by the low interest shown for it on github. My best judgment is that it's too niche to move forward, and that it degrades UX. Of course both are subjective. But given that we have little (and sample-biased) data, and that I've been maintaining this and listening/discussing with users through 2000 tickets, it seems to me that, until someone takes over, my opinion might be considered the most informed, and my decision to not move forward with this PR reasonable. I understand though, that from where you stand, this PR looks like a clear win. I'm sorry about that 🙇 |
Ultimately this is what I wanted to do, but it appeared to involve considerably more effort.
I wish there was some way to better quantify this. The previous tab behavior really threw me off when I first used the app, and I wonder if others feel the same.
can't argue with you there ;-)
It's all good, and this is one of the ways in which open source is great. Hopefully it won't be too burdensome to maintain the fork, although I have little experience exposing the binaries to users, auto update, and that sort of thing. So it'll be a fun growth opportunity. fwiw you do an excellent job handling user feedback and PRs, particularly with the way in which you deliver bad news and show empathy. Be proud :-) Ultimately I love the app and thank you for making it something we're even talking about. Thanks! |
Implements feature request #2209.
This allows for alt-tab to handle cycling backwards in the same way many window managers operate: by including
shift
in the key combo. Without this, only one shortcut can operate under this model.It defaults to the same behavior that's existed (⇧ cycles backwards), and migration will bind all shortcut keys to whatever is existing, ensuring functional equivalency until a user explicitly changes it.