[Snyk] Upgrade typescript from 4.9.5 to 5.0.2 (#279)

* feat: upgrade typescript from 4.9.5 to 5.0.2 Snyk has created this PR to upgrade typescript from 4.9.5 to 5.0.2. See this package in npm: https://www.npmjs.com/package/typescript See this project in Snyk: https://app.snyk.io/org/lukemnet/project/c8ad1a9e-c1bb-49f5-8a01-578e0d6df8cf?utm_source=github&utm_medium=referral&page=upgrade-pr * Fix checkIfProfileIdLooksValid method to work with TS 5.x --------- Co-authored-by: snyk-bot <[email protected]>
lwojcik · Apr 19, 2023 · 517b365 · 517b365
1 parent 128bd4f
commit 517b365
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -69,7 +69,7 @@
     "rollup-plugin-esbuild": "^5.0.0",
     "sort-package-json": "^2.4.1",
     "ts-jest": "^29.0.5",
-    "typescript": "^4.9.5"
+    "typescript": "^5.0.2"
   },
   "licenses": [
     {

diff --git a/src/helpers/profileIds/checkIfProfileIdLooksValid.ts b/src/helpers/profileIds/checkIfProfileIdLooksValid.ts
@@ -1,3 +1,3 @@
 export const checkIfProfileIdLooksValid = (profileId: number | string) =>
-  profileId > 0 &&
+  Number(profileId) > 0 &&
   profileId.toString() === parseInt(profileId as string, 10).toString();
diff --git a/tests/__testData__/invalidProfileIds.json b/tests/__testData__/invalidProfileIds.json
@@ -1 +1 @@
-[-1, "a33434", "nodigitshere", "12121g3424"]
+[-1, 0, "a33434", "nodigitshere", "12121g3424"]