Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr reviewers participants #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Bob343
Copy link
Contributor

@Bob343 Bob343 commented Feb 21, 2021

@lvermeulen This is adding some additional functionality onto the Pull Request queries, allowing you to pull back reviewers + participants with the query. Two "questionable" pieces that I wasn't sure if it really aligned with the rest of this implementation:

  1. In BitbucketCloudClient.cs I defaulted the PR query to now pulling reviewers + participants, should this be an option to the method instead? Either boolean to pull participants + reviewers, or allow passing in fields in general as a string parameter which could be useful for other scenarios where something isn't by default included in the payload.
  2. Participant.cs - I added a "User" object as an attribute to the Participant which felt weird, considering Participant is an extension of a User to begin with. But in the response payload from the API, the "user" object is a child of each "participant" in the array. So each participant object doesn't actually contain the identifiable information, the child User object does:
    image

Let me know if you want any of this changed. Thanks!

Zachary Vampola and others added 3 commits November 22, 2020 13:06
@Bob343
Copy link
Contributor Author

Bob343 commented Mar 26, 2021

Hi @lvermeulen ! Would this be able to be incorporated in a release? Thanks!

@Bob343
Copy link
Contributor Author

Bob343 commented Apr 18, 2023

Hey @lvermeulen - any chance this would be able to be merged?

@infigo-victor
Copy link

Hey @lvermeulen - is there any change that this will be merged any time soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants