-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Expand docs. #154
base: main
Are you sure you want to change the base?
Tests: Expand docs. #154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 36.15% 36.16% +0.01%
==========================================
Files 70 70
Lines 3986 3987 +1
==========================================
+ Hits 1441 1442 +1
Misses 2545 2545 ☔ View full report in Codecov by Sentry. |
|
||
There are 4 required parameters that need to be set when triggering the Github action: | ||
|
||
- `additional-parameter`: The parameter that specifies the desired test. Default is `-all` which runs tests on all public models. The available options are: `-all`, `-p <parser_name>`, `-s <slug_1> <slug_2> ...`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slug
should be renamed to model
(or HubAI model identifier
). I'd also fix the argument call from -s
to -m
(model)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just what @jkbmrz mentioned
This PR expands Readmes in E2E and Integration tests so the required parameters are described.