fix(images): bound bridge iteration buffering - #67
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
|
Closing this original proposal after reimplementing its useful scope with current code and executable regression coverage. Follow-up now belongs to the submitted implementation and its review/CI; this closure does not claim the change has merged. |
Motivation
Description
appendBoundedIterationEventand charging againstTRANSLATOR_MAX_TURN_BYTES, which causes a typedTranslatorBudgetExceededErrorwhen exceeded.tool_call_deltachunks by trackingpendingArgsBytesand throwingTranslatorBudgetExceededErroronceTRANSLATOR_MAX_CALL_ARGUMENT_BYTESis exceeded.runTurnadapter collection and the streamedparseStreamWithProgresspath so runTurn and non-runTurn adapters are both protected.tests/images/loop.test.tsthat assert oversized semantic output and oversized synthetic tool-argument streams produce atranslation_buffer_limitfailure rather than allowing the bridge to complete.Testing
bun test tests/images/loop.test.ts— focused image-bridge tests passed (31 tests).bun run typecheck— TypeScript typecheck passed.bun run privacy:scan— privacy scan passed for changed files.bun run test— full test suite encountered an unrelated timeout / auth-status mismatch in an unrelated provider validation test; focused image-bridge tests remain green.