Conversation
…43-01a07240 [WRONG BRANCH] chore(release): promote verified candidate to 2.43.0
…lease-244-main-07c0
…in-07c0 chore(release): promote validated 2.44.0 to main
Promote frozen dev source cf9f662; no new runtime changes. Candidate CI34061274315 and service34061276621 are the validation references. Publication waits for successful validation and the final main push CI at the exact release SHA.
Promote frozen dev source cf9f662 as 2.45.0. The repository owner explicitly authorized this main/preview release promotion and admin PR-only merge. This is a release-specific owner decision, not an independent approval or the dev-only maintainer exception. Frozen candidate full CI34061274315 passed all25jobs after one unchanged-source rerun of Windows5; the initial holder busy assertion remains recorded without a root-cause resolution claim. Service lifecycle34061276621 passed Linux/macOS/Windows. Dev version pre-move3812 is merged. Publication still requires this actual main merge SHA's own successful push CI and Service lifecycle. No local suites were run.
[WRONG BRANCH] chore(release): promote verified 2.46.0 to main
[WRONG BRANCH] release: promote 2.47.0 to main
[WRONG BRANCH] release: apply final roster correction to main
[WRONG BRANCH] release: promote 2.48.0 to main
…in-01a08498 release: promote verified 2.49.0 product tree to main
…in-01a08a81 [WRONG BRANCH] release: promote verified 2.50.0 product tree to main
[WRONG BRANCH] release: promote verified 2.51.0 product tree to main
Product tree is dev at 7bfb2ad. Only package.json differs, carrying the stable channel version 2.52.0. This promotion follows a CI repair and a regression sweep: dev had drifted 79 commits past its last finished run and the one run allowed to complete had failed. lidge-jun#4390 fixed an integration test that never denied anything and had been red on dev since lidge-jun#4342; lidge-jun#4396/lidge-jun#4397/lidge-jun#4398 closed four gaps in the quota avoidance contract lidge-jun#4368 introduced; lidge-jun#4403 made a port fixture deterministic.
release: promote verified 2.52.0 product tree to main
Product tree is dev at eb81eaa, byte-identical (dev already carries the 2.53.0 version line). This promotion follows a 364-commit regression audit (origin/main..981b53e) by 15 parallel subagent lanes plus two audit-spawned fixes reviewed and merged to dev: lidge-jun#4496 (live sideband connect watchdog) and lidge-jun#4497 (chat image part shapes). Zero unresolved P0/P1 at promotion time. Exact-head hosted CI green on eb81eaa (run 34750934849). Local suite NOT RUN per task rule; hosted exact-head CI is the gate.
[WRONG BRANCH] release: promote verified 2.53.0 product tree to main
Product tree is dev at a84e6e8, byte-identical (dev already carries the 2.54.0 version line). Headed by the Codex model-picker incident fix (lidge-jun#4531). On Codex 0.154.0-alpha.6.2 a paginated-history preflight vetoed the entire Codex config write, so model_catalog_json never reached config.toml and both the Codex app and the CLI fell back to their six built-in models, while ocx sync reported that failure as success. The refusal is now scoped to the conversation-history relabel unit on the apply direction only, narrowed to the one permanent reason, and a provider table the home already published survives the write. Exact-head hosted CI green on a84e6e8 via lidge-jun#4531 (run 34772128322): all four Linux test shards, both macOS shards, gates, hygiene, storage policy, api usage, keyring x3, npm-global x3, docker smoke, react-doctor. Local suite NOT RUN per task rule; hosted exact-head CI is the gate.
[WRONG BRANCH] release: promote verified 2.54.0 product tree to main
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de7b4a171c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cancel(reason) { | ||
| cancelled = true; | ||
| void iterator.return?.(reason); | ||
| void iterator.return?.(reason).finally(finalize); |
There was a problem hiding this comment.
When the client cancels while pull() is awaiting an upstream SSE chunk, an async generator's return() waits for the pending reader.read() before entering its finally; chaining finalize to that promise therefore leaves the sole recovery-probe lease held until the upstream produces data or is separately aborted. This is especially visible on the tee relay path, whose inspection branch may continue draining after client disconnection, so subsequent recovery probes remain blocked despite this cancellation fix. Invoke finalize() synchronously in cancel() and then request iterator/reader shutdown independently.
AGENTS.md reference: src/AGENTS.md:L17-L17
Useful? React with 👍 / 👎.
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
changed the title
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
luvs01
changed the title
2 participants
Motivation
Description
onFinalize?: () => voidhook toPassthroughWebSearchBridgeStreamOptionsand wire an exactly-oncefinalize()increatePassthroughWebSearchBridgeStreamthat runs on normal completion, error, or client cancellation. (src/web-search/passthrough-bridge.ts)releaseCodexAuthContextProbeLease(openAiSidecar?.authContext)so any probe lease acquired during early OpenAI-sidecar resolution is returned when no upstream sidecar request occurs. (src/server/responses/core.ts)tests/web-search/web-search-passthrough-bridge.test.ts)structure/runtime.md)Testing
node_modules/.bin/bun test tests/web-search/web-search-passthrough-bridge.test.tsand the file's suite passed (41 tests, 0 failures).node_modules/.bin/bun run typecheck,node_modules/.bin/bun run structure:check, andnode_modules/.bin/bun run privacy:scan, all of which succeeded for the change set.bun testin this environment; the full suite exercise succeeded for the modified bridge tests but the run exposed unrelated environment-sensitive failures in the Codex shim process-group cleanup tests (external to this change); these are not regressions introduced by this PR.git diff --checkshowed no whitespace or diff issues.Codex Task