Conversation
…43-01a07240 [WRONG BRANCH] chore(release): promote verified candidate to 2.43.0
…lease-244-main-07c0
…in-07c0 chore(release): promote validated 2.44.0 to main
Promote frozen dev source cf9f662; no new runtime changes. Candidate CI34061274315 and service34061276621 are the validation references. Publication waits for successful validation and the final main push CI at the exact release SHA.
Promote frozen dev source cf9f662 as 2.45.0. The repository owner explicitly authorized this main/preview release promotion and admin PR-only merge. This is a release-specific owner decision, not an independent approval or the dev-only maintainer exception. Frozen candidate full CI34061274315 passed all25jobs after one unchanged-source rerun of Windows5; the initial holder busy assertion remains recorded without a root-cause resolution claim. Service lifecycle34061276621 passed Linux/macOS/Windows. Dev version pre-move3812 is merged. Publication still requires this actual main merge SHA's own successful push CI and Service lifecycle. No local suites were run.
[WRONG BRANCH] chore(release): promote verified 2.46.0 to main
[WRONG BRANCH] release: promote 2.47.0 to main
[WRONG BRANCH] release: apply final roster correction to main
[WRONG BRANCH] release: promote 2.48.0 to main
…in-01a08498 release: promote verified 2.49.0 product tree to main
…in-01a08a81 [WRONG BRANCH] release: promote verified 2.50.0 product tree to main
[WRONG BRANCH] release: promote verified 2.51.0 product tree to main
Product tree is dev at 7bfb2ad. Only package.json differs, carrying the stable channel version 2.52.0. This promotion follows a CI repair and a regression sweep: dev had drifted 79 commits past its last finished run and the one run allowed to complete had failed. lidge-jun#4390 fixed an integration test that never denied anything and had been red on dev since lidge-jun#4342; lidge-jun#4396/lidge-jun#4397/lidge-jun#4398 closed four gaps in the quota avoidance contract lidge-jun#4368 introduced; lidge-jun#4403 made a port fixture deterministic.
release: promote verified 2.52.0 product tree to main
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f5554c709
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // A positive stored threshold only steers selection once the pool consumes it, which is | ||
| // exactly what `inert: false` reports. Zero remains the explicit disabled value. | ||
| const enabled = inert === false && storedThreshold !== null && storedThreshold > 0; |
There was a problem hiding this comment.
This changes src/cli/, but structure/manifest.json also maps that area to structure/clients/claude-desktop.md and structure/ops/docs-and-release.md, neither of which is updated by this commit. Synchronize those mapped owners with the new zero-threshold CLI contract, or correct the ownership map if they no longer describe this area.
AGENTS.md reference: src/AGENTS.md:L10-L11
Useful? React with 👍 / 👎.
| * quota-less provider off its active account on the very first request. | ||
| */ | ||
| function isOverAutoSwitchThreshold(providerName: string, accountId: string, threshold: number): boolean { | ||
| if (threshold <= 0) return false; |
There was a problem hiding this comment.
With this guard, the public configuration reference is now contradictory: docs-site/src/content/docs/reference/configuration/providers.md:573 still defines the full 0–100 range as the usage percentage at which fill-first advances, which makes zero read as immediate rotation rather than disabled, and the CLI reference still says inert: false means the threshold is being applied. Update the English references and translations to state that zero disables usage-based generic fill-first switching while reactive recovery remains active.
AGENTS.md reference: AGENTS.md:L380-L381
Useful? React with 👍 / 👎.
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
2 participants
Motivation
autoSwitchThresholdis explicitly set to0, which previously evaluated as exceeded and could move requests and billing to another pooled account.0 = disabledfor usage-driven auto-switching while leaving reactive recovery (429/401 driven) unchanged.Description
isOverAutoSwitchThresholdsothreshold <= 0always returnsfalse, disabling proactive switching when the stored threshold is non-positive (src/oauth/generic-account-failover.ts).offstate (src/cli/account-extended.ts).fill-firstholds the active account whenautoSwitchThresholdis0and that the CLI status JSON reports a zero threshold as disabled (tests/oauth/generic-oauth-failover.test.ts,tests/cli/cli-account-pool-verbs.test.ts).structure/config.md,structure/transports/inventory.md,structure/runtime.md).Testing
./node_modules/bun/bin/bun.exe test tests/oauth/generic-oauth-failover.test.ts, and the suite covering the new regressions passed (44 tests passed for that file)../node_modules/bun/bin/bun.exe test tests/cli/cli-account-pool-verbs.test.ts, and the CLI-focused tests passed (30 tests passed for that file).bun run typecheckandbun run privacy:scan(via the pinned Bun) and both succeeded.bun run structure:checkand it passed to keep structure/ docs in sync.bun run testin the current container encountered unrelated environment/system-level failures (external fixtures and environment-generated403responses); the focused tests and gates relevant to this change are green.Codex Task