Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce crossings of connection lines #1409

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

beru
Copy link

@beru beru commented Dec 15, 2024

This PR is a sequel of #1330, #1327 and #1261.

The crossings around the green rectangles are cleared.

retinanet_resnet50_fpn_v2_Opset18.onnx

Left : Before
Right : Ater

Untitled

image

efficientdet-d3.onnx

Left : Before
Right : Ater

Untitled

saved_model.pbtxt

Left : Before
Right : Ater

image

image

image

@lutzroeder
Copy link
Owner

@beru is it possible not regress existing layouts with this change? For example, in the yolov5n.onnx screenshot the residual and Sigmoid changed sides.

@beru beru marked this pull request as draft December 16, 2024 12:22
@beru beru force-pushed the beru-mitigate-crossings-no4 branch from f63710d to cdd32aa Compare December 16, 2024 13:10
@beru beru marked this pull request as ready for review December 16, 2024 13:16
@beru
Copy link
Author

beru commented Dec 16, 2024

@lutzroeder

is it possible not regress existing layouts with this change? For example, in the yolov5n.onnx screenshot the residual and Sigmoid changed sides.

I've resolved the problem. Now I don't see the unnecessary changes with yolov5n.onnx model.


I ran npm test but it failed before completion.

dot/mb_v1_ssd_with_flag.dot
TypeError: node.metadata.keys(...).every is not a function

I see the same error with current main branch (0ffe6bc)

@beru beru marked this pull request as draft December 16, 2024 17:03
@beru beru marked this pull request as ready for review December 16, 2024 17:24
@lutzroeder lutzroeder force-pushed the main branch 5 times, most recently from 5073b0e to c23cc32 Compare December 18, 2024 19:16
@beru beru force-pushed the beru-mitigate-crossings-no4 branch from 410af34 to 980dac6 Compare December 19, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants