Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: Add best practices, overview, and run explanation #65

Merged
merged 11 commits into from
Nov 14, 2024

Conversation

andrewwormald
Copy link
Collaborator

Updates the README with best practices, explanation of the Run, and the role of the role scheduler.

@andrewwormald andrewwormald force-pushed the andreww-updateReadmeWithBestPractices branch from 1d1cc4b to 025d732 Compare November 8, 2024 13:04
@andrewwormald andrewwormald changed the title workflow: Add best practices, overview, and run explanation readme: Add best practices, overview, and run explanation Nov 8, 2024
@andrewwormald andrewwormald marked this pull request as ready for review November 8, 2024 16:15
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@echarrod echarrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌 I'm a fan of more commas, but feel free to ignore 😁

andrewwormald and others added 5 commits November 13, 2024 16:36
Co-authored-by: Ed Harrod <[email protected]>
Co-authored-by: Ed Harrod <[email protected]>
Co-authored-by: Ed Harrod <[email protected]>
Co-authored-by: Ed Harrod <[email protected]>
Co-authored-by: Ed Harrod <[email protected]>
@andrewwormald
Copy link
Collaborator Author

Thanks for the great review @echarrod! If it adds value, even grammatically, then I appreciate it 😁

Copy link

sonarcloud bot commented Nov 14, 2024

@andrewwormald andrewwormald merged commit 74065b0 into main Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants