Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hooks: Apply hooks suggestions #146

Merged
merged 12 commits into from
Nov 6, 2024
Merged

hooks: Apply hooks suggestions #146

merged 12 commits into from
Nov 6, 2024

Conversation

echarrod
Copy link
Contributor

@echarrod echarrod commented Oct 3, 2024 •
edited
Loading

Changed

  • Made hook suggestions, we won't be defining external pre-commit config yet

@echarrod echarrod marked this pull request as ready for review October 3, 2024 14:25
echarrod
echarrod commented Oct 8, 2024
View reviewed changes
echarrod
echarrod commented Oct 8, 2024
View reviewed changes
@echarrod echarrod changed the title style: Add pre-commit hooks hooks: Apply hooks suggestions Nov 6, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

t4vvd
t4vvd reviewed Nov 6, 2024
View reviewed changes
Copy link

@t4vvd t4vvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letting this run with the approval.
Want to see how it can effect Luno API trading !

@echarrod echarrod merged commit 3f47a7d into main Nov 6, 2024
5 checks passed
@echarrod echarrod deleted the ed-precommit branch November 6, 2024 17:18
@t4vvd
Copy link

t4vvd commented Nov 6, 2024

Looking forward to seeing where this leads to from merger to main on Luno!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t4vvd t4vvd t4vvd left review comments

@arcturial arcturial arcturial approved these changes

@andrewwormald andrewwormald andrewwormald approved these changes

@neilgarb neilgarb Awaiting requested review from neilgarb

@wesrobin wesrobin Awaiting requested review from wesrobin

@wenkanglu wenkanglu Awaiting requested review from wenkanglu

@adamhicks adamhicks Awaiting requested review from adamhicks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@echarrod @t4vvd @arcturial @andrewwormald