Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

598 feed plugin image support #599

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

negrel
Copy link
Contributor

@negrel negrel commented Apr 18, 2024

Description

Add image support to feed plugin.

Related Issues

Addresses #598.

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

plugins/feed.ts Outdated Show resolved Hide resolved
@negrel negrel force-pushed the 598-feed-plugin-image-support branch from 8025256 to 46a7e5e Compare April 19, 2024 11:40
@oscarotero
Copy link
Member

Thanks. The tests are failing due the new image file in the assets folder. Can you run deno task test tests/feed.test.ts -- --update to update it?

@negrel
Copy link
Contributor Author

negrel commented Apr 19, 2024

Thanks. The tests are failing due the new image file in the assets folder. Can you run deno task test tests/feed.test.ts -- --update to update it?

It seems that my change to test site also impacted snapshot of other tests. I've updated snapshot of those test in a separate commit. I can't run test suite locally, favicon test seems to never end so some failing test may remain. Let me know if that's the case.

@oscarotero
Copy link
Member

The favicon issue is a bug from Deno in its support for NPM packages (denoland/deno#21686)

I'm using Deno 1.38.5 to run the tests because it's the most recent version without this bug. You can run deno upgrade --version 1.38.5 to update the tests. Then back to the latest Deno version with deno upgrade.

@negrel
Copy link
Contributor Author

negrel commented Apr 19, 2024

Should be ok now.

@oscarotero oscarotero merged commit 70e0398 into lumeland:main Apr 19, 2024
3 checks passed
@oscarotero
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants