fix port/location calculation

CHANGELOG.md

@@ -18,6 +18,7 @@ Go to the `v1` branch to see the changelog of Lume 1.
 - For better predictability, the `_cache` folder is generated in the root folder, instead of `src` folder.
 - Simplified Esbuild plugin.
 - Import `std` packages from `jsr` because they are not longer updated on `land/x`.
+- The default port when lume build the site (not serving) is `80` or `443`, depending whether the location protocol is http or https. Previously it was `3000`.
 
 ### Deprecated
 - `liquid` plugin. It never worked well with `search.pages()` [#600].

core/site.ts

@@ -134,7 +134,6 @@ export default class Site {
 
   constructor(options: Partial<SiteOptions> = {}) {
     this.options = merge(defaults, options);
-    this.options.location.port ||= this.options.server.port.toString();
 
     const src = this.src();
     const dest = this.dest();

core/utils/cli_options.ts

@@ -20,20 +20,38 @@ export function getOptionsFromCli(
     options.dest = cli.dest;
   }
 
+  if (cli.port) {
+    (options.server ||= {}).port = parseInt(cli.port);
+  } else if (cli.serve) {
+    (options.server ||= {}).port = 3000;
+  }
+
+  let location: URL;
+
   if (cli.location) {
-    options.location = new URL(cli.location);
-  } else if (cli.serve || cli._[0] === "cms") {
-    options.location = new URL(`http://localhost:${cli.port || 3000}/`);
+    location = new URL(cli.location);
+  } else if (options.location && !cli.server) {
+    location = options.location as URL;
+  } else {
+    location = new URL("http://localhost");
   }
 
-  if (cli.port) {
-    (options.server ||= {}).port = parseInt(cli.port);
+  let port: number;
 
-    if (options.location) {
-      options.location.port = cli.port;
-    }
+  if (cli.port) {
+    port = parseInt(cli.port);
+  } else if (location.port) {
+    port = parseInt(location.port);
+  } else if (options.server?.port) {
+    port = options.server.port;
+  } else {
+    port = cli.serve ? 3000 : location.protocol === "https:" ? 443 : 80;
   }
 
+  (options.server ||= {}).port = port;
+  location.port = port.toString();
+  options.location = location;
+
   if (cli.open) {
     (options.server ||= {}).open = cli.open;
   }

tests/config.test.ts

@@ -13,7 +13,7 @@ Deno.test("default configuration", () => {
   equals(options.dest, "./_site");
   equals(options.location.href, "http://localhost/");
   equals(options.prettyUrls, true);
-  equals(options.server.port, 3000);
+  equals(options.server.port, 80);
   equals(options.server.page404, "/404.html");
   equals(options.server.open, false);
 });