JAX checkpointing via Orbax #1491
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the information here https://orbax.readthedocs.io/en/latest/, Orbax is not a package, but rather a separate package for each functionality provided by the Orbax namespace. For checkpoint, we need orbax-checkpoint |
tttc3
force-pushed
the
orbax-checkpointing
branch
from
4764729
to
458d880
Compare
|
I've updated the import to only require |
|
As checkpoint is a very basic tool, I think it is ok to add it to the required package dependency. |
tttc3
force-pushed
the
orbax-checkpointing
branch
from
4fedf8e
to
827f686
Compare
tttc3
force-pushed
the
orbax-checkpointing
branch
from
827f686
to
42706b3
Compare
|
Added orbax-checkpoint as a top level import and a package wide dependency. Still have |
lululxvi
reviewed
Sep 26, 2023
| @@ -1,5 +1,6 @@ | |||
| matplotlib | |||
| numpy | |||
| orbax-checkpoint | |||
There was a problem hiding this comment.
Need to move this to the JAX part below.
lululxvi
reviewed
Sep 26, 2023
| @@ -37,6 +37,7 @@ classifiers = [ | |||
| dependencies = [ | |||
| "matplotlib", | |||
| "numpy", | |||
| "orbax-checkpoint", | |||
lululxvi
reviewed
Sep 26, 2023
| @@ -1,5 +1,6 @@ | |||
| matplotlib | |||
| numpy | |||
| orbax-checkpoint | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1490 . Provides a very basic checkpointing functionality for flax based JAX models via Orbax. Essentially follows the simple example from flax documentation, without the use of the context manager.
As noted in #1490 , Orbax is currently imported lazily (only imported once first called) in a non PEP8 compliant manner, to avoid requiring Orbax as a package dependency. I feel that there should be a better way to do this, but I can't currently think of one.
As such, I've marked this as a draft for now.
Any thought or suggestions are greatly appreciated!