Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1554

Merged
merged 31 commits into from
Feb 10, 2025
Merged

🌐 New Crowdin updates #1554

merged 31 commits into from
Feb 10, 2025

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Feb 8, 2025

Summary by CodeRabbit

  • New Features

    • Enhanced Brazilian Portuguese localization by removing outdated entries.
    • Added new entries for Basque localization related to email changes and user registration.
    • Introduced a new entry for quick blog creation in Basque localization.
    • Added multiple entries for email verification notifications in Basque localization.
    • Updated localization files for multiple languages, removing unnecessary entries related to user identification and guest users.
    • Introduced error handling messages for request limits in English localization.
  • Style

    • Refined Brazilian Portuguese interface text for improved consistency and clarity.
    • Updated Basque localization for user identification and guest user description for clarity.

@vercel vercel bot temporarily deployed to Preview – landing February 8, 2025 17:39 Inactive
Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2025 2:04pm
landing ⬜️ Skipped (Inspect) Feb 9, 2025 2:04pm

Copy link
Contributor

coderabbitai bot commented Feb 8, 2025

Walkthrough

The update modifies localization files across multiple languages, primarily focusing on the removal of keys related to user identification and guest user information. The "forgetMe" and "userId" keys have been removed from various localization files, including Brazilian Portuguese, Basque, and several others. Additionally, new keys have been added in the Basque localization file related to email changes and user registration, while minor formatting adjustments were made in other files.

Changes

File Change Summary
apps/web/.../pt-BR/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription"; updated "aboutGuest" from "Usuário Convidado" to "Usuário convidado".
apps/web/.../eu/app.json Removed keys: "forgetMe" and "userId"; updated "aboutGuest" and added multiple new keys related to email changes and user registration.
apps/landing/.../eu/home.json Added new entry "quickCreateBlog" with value "Begiratu Sortze azkarra" and modified "meetingPollMetaDescription" for formatting.
packages/emails/.../eu/emails.json Added multiple new entries related to email verification for changing email addresses, including preview messages and instructions.
apps/web/.../ca/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../cs/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../da/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../de/app.json Removed keys: "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../es/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../fi/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../fr/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../hr/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../hu/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription"; added "tooManyRequests" and "tooManyRequestsDescription".
apps/web/.../it/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../ja/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../ko/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../nl/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../no/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../pl/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../ru/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../sk/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../sv/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../tr/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../zh-Hant/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../zh/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription".
apps/web/.../en/app.json Removed keys: "forgetMe", "userId", "aboutGuest", and "aboutGuestDescription"; added keys: "tooManyRequests" and "tooManyRequestsDescription".

Possibly related PRs

  • 🌐 New Crowdin updates #1494: The changes in the main PR involve the removal and modification of localization keys related to user identification and guest user information in the Brazilian Portuguese localization file, which is related to similar modifications in the Czech localization file.
  • 🌐 New Crowdin updates #1545: The changes in the main PR and the retrieved PR are related as both involve the removal of the same localization keys ("forgetMe", "userId", and "aboutGuest") from their respective JSON files for different languages, indicating a similar adjustment in handling user and guest information.
  • 🌐 New Crowdin updates #1516: The changes in the main PR, which involve the removal and modification of localization keys related to user identification and guest users in Brazilian Portuguese, are related to the retrieved PR, which also includes similar modifications to localization keys in the Italian localization file, specifically the removal of keys like "forgetMe" and "userId".

Poem

Oh, hop along with me,
A little tweak sets words so free!
Code now sings in Portuguese light,
Each change a joyful, gentle bite.
With bunny cheer, our code takes flight! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f0cd62b and 10b1c92.

📒 Files selected for processing (1)
  • apps/web/public/locales/hu/app.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/web/public/locales/hu/app.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel vercel bot temporarily deployed to Preview – landing February 8, 2025 21:39 Inactive
@vercel vercel bot temporarily deployed to Preview – landing February 8, 2025 23:20 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/landing/public/locales/eu/home.json (1)

42-42: Formatting Adjustment for meetingPollMetaDescription
The entry's value has been updated by removing an unnecessary line break while keeping the text content intact. Verify that the change in spacing does not affect the rendering in the front end.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1bbc239 and f8d55e4.

📒 Files selected for processing (3)
  • apps/landing/public/locales/eu/home.json (1 hunks)
  • apps/web/public/locales/eu/app.json (2 hunks)
  • packages/emails/locales/eu/emails.json (1 hunks)
🔇 Additional comments (5)
apps/landing/public/locales/eu/home.json (1)

43-43: New Key Addition: quickCreateBlog
A new localization entry "quickCreateBlog" with the value "Begiratu Sortze azkarra" has been added. Please confirm that the translation aligns with the overall tone and context for quick blog creation across the platform.

packages/emails/locales/eu/emails.json (1)

50-56: New Email Change Notification Entries
A set of new entries related to the email address change flow (preview, heading, button, subject, and text messages) have been introduced. They follow a clear instructional style and include HTML placeholders where applicable. Please verify that these placeholders (e.g., {{fromEmail}}) are correctly processed by the email templating system and that the tone is consistent with other notification messages.

apps/web/public/locales/eu/app.json (3)

202-204: Updated User Identification and Guest Description
The "userId" key has been updated from "Erabiltzailearen ID-a" to "Erabiltzailearen IDa" (removing the hyphen), and "aboutGuestDescription" has been revised for clarity. Ensure that these modifications are consistent with the design guidelines and propagated throughout all parts of the application where these texts are used.


273-279: New Unsubscribe and Email Change Notification Keys
New keys such as "unsubscribeToastTitle", "unsubscribeToastDescription", "emailChangeSuccess", "emailChangeFailed", "emailChangeInvalidToken", and "emailChangeError" have been added. These entries are essential for guiding users through the email change process and handling error feedback. Please double-check that the phrasing and tone match the overall messaging style, and confirm that any dynamic placeholders (if used in the future) will be integrated seamlessly.


280-308: Additional Keys for Account Management and User Onboarding
A comprehensive range of new entries has been added for various aspects of account management, including keys for "emailChangeRequestSent", "profileEmailAddress", third‐party login prompts ("continueWith", "continueWithProvider"), and several keys related to login, registration, and quick action prompts. Review these entries to ensure they provide clear guidance to users and maintain consistency with both the visual UI components and similar texts in other locales.

@vercel vercel bot temporarily deployed to Preview – landing February 9, 2025 07:55 Inactive
@vercel vercel bot temporarily deployed to Preview – landing February 9, 2025 09:55 Inactive
@vercel vercel bot temporarily deployed to Preview – landing February 9, 2025 14:04 Inactive
@lukevella lukevella merged commit 8ff8058 into main Feb 10, 2025
5 checks passed
@lukevella lukevella deleted the l10n_main branch February 10, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant