Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1533

Merged
merged 12 commits into from
Jan 31, 2025
Merged

🌐 New Crowdin updates #1533

merged 12 commits into from
Jan 31, 2025

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Jan 30, 2025

Summary by CodeRabbit

  • Localization
    • Added Norwegian language translations for user account management and email notifications.
    • Included user-friendly notifications for email changes, registration, and login processes.
    • Enhanced error handling and user feedback for email-related operations.
    • Modified English localization for provider continuation syntax.

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 8:04am
landing ⬜️ Skipped (Inspect) Jan 31, 2025 8:04am

@vercel vercel bot temporarily deployed to Preview – landing January 30, 2025 21:56 Inactive
Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Warning

Rate limit exceeded

@lukevella has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 29cdd3d and 2b4f288.

📒 Files selected for processing (9)
  • apps/web/public/locales/da/app.json (1 hunks)
  • apps/web/public/locales/de/app.json (1 hunks)
  • apps/web/public/locales/fi/app.json (1 hunks)
  • apps/web/public/locales/hu/app.json (1 hunks)
  • apps/web/public/locales/it/app.json (1 hunks)
  • apps/web/public/locales/nl/app.json (1 hunks)
  • apps/web/public/locales/no/app.json (1 hunks)
  • apps/web/public/locales/pt-BR/app.json (1 hunks)
  • apps/web/public/locales/sv/app.json (1 hunks)

Walkthrough

This pull request updates the Norwegian (no) localization file for a web application by adding multiple new key-value pairs related to user account management and email notifications. The changes enhance the localization for actions such as email updates, user registration, and login processes, providing clearer messages for users regarding their account interactions. Additionally, a modification was made to the English (en) localization file to correct the placeholder syntax for variable substitution.

Changes

File Changes
apps/web/public/locales/no/app.json Added 36 new localization keys:
- unsubscribeToastTitle
- unsubscribeToastDescription
- emailChangeSuccess
- emailChangeSuccessDescription
- emailChangeFailed
- emailChangeInvalidToken
- emailChangeError
- emailChangeRequestSent
- emailChangeRequestSentDescription
- profileEmailAddress
- profileEmailAddressDescription
- emailAlreadyInUse
- continueWith
- continueWithProvider
- loginFooter
- alreadyHaveAccount
- loginDescription
- loginTitle
- registerTitle
- registerDescription
- quickActionsDescription
- quickCreateGroupPoll
- quickCreate
- quickCreateRecentlyCreated
- quickCreateWhyCreateAnAccount
- quickCreateSecurePolls
- quickCreateGetNotifications
- quickCreateManagePollsFromAnyDevice
- registerVerifyTitle
- registerVerifyDescription
- loginVerifyTitle
- loginVerifyDescription
- createAccount
apps/web/public/locales/en/app.json Modified string:
- Changed "continueWithProvider": "Continue with {{provider}}" to "continueWithProvider": "Continue with {provider}"

Possibly related PRs

  • 🌐 New Crowdin updates #1494: This PR introduces new entries related to email change notifications, which are directly relevant to the changes made in the main PR regarding email management and user notifications.
  • 🌐 New Crowdin updates #1499: This PR adds the emailAlreadyInUse message, which aligns with the main PR's focus on enhancing user feedback related to email changes.
  • 🌐 New Crowdin updates #1505: This PR includes multiple new strings for email management, including success and failure notifications for email changes, which are directly related to the main PR's updates.

Poem

🐰 In Norway's lands, where rabbits play,
New words for emails brighten the day!
From changes to logins, all clear and bright,
Hopping through messages, a joyful sight!
Localization blooms, like flowers in spring,
With every new string, our hearts start to sing! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel vercel bot temporarily deployed to Preview – landing January 30, 2025 23:03 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 142581a and 7ad1ac4.

📒 Files selected for processing (1)
  • apps/web/public/locales/no/app.json (1 hunks)
🔇 Additional comments (4)
apps/web/public/locales/no/app.json (4)

273-274: LGTM: Email notification messages are clear and consistent.

The unsubscribe toast messages are properly translated and maintain consistency with the existing notification-related terminology in the file.


275-284: LGTM: Email change flow messages are well structured.

The email change flow messages are properly translated and cover all necessary states (success, failure, invalid token, etc.). The messages maintain consistency with existing email-related terminology in the file.


287-287: LGTM: Login/Register link messages properly handle HTML.

The messages correctly use <a> tags for the registration and login links, maintaining consistency with other link-containing messages in the file.

Also applies to: 290-290


291-308: LGTM: Authentication flow messages are complete and consistent.

The authentication flow messages (login, register, verification) are properly translated and maintain a consistent tone and terminology throughout the flow.

apps/web/public/locales/no/app.json Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – landing January 31, 2025 07:03 Inactive
@vercel vercel bot temporarily deployed to Preview – landing January 31, 2025 08:03 Inactive
@lukevella lukevella merged commit 7de0d5b into main Jan 31, 2025
5 checks passed
@lukevella lukevella deleted the l10n_main branch January 31, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant