Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1471

Merged
merged 10 commits into from
Jan 3, 2025
Merged

🌐 New Crowdin updates #1471

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae063f7
New translations emails.json (Korean)
lukevella Dec 27, 2024
10a35aa
New translations emails.json (Korean)
lukevella Dec 27, 2024
7e3d5c1
New translations pricing.json (German)
lukevella Dec 28, 2024
7c51d46
New translations app.json (Spanish)
lukevella Dec 30, 2024
59cc613
New translations common.json (Spanish)
lukevella Dec 30, 2024
1309844
New translations app.json (Spanish)
lukevella Dec 30, 2024
220e089
New translations emails.json (Spanish)
lukevella Dec 30, 2024
df86d34
New translations emails.json (Spanish)
lukevella Dec 30, 2024
6aa4537
New translations home.json (Spanish)
lukevella Dec 30, 2024
21ad524
New translations pricing.json (Spanish)
lukevella Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/emails/locales/ko/emails.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
{
"common_poweredBy": "Powered by <a>{{domain}}</a>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Text needs to be translated to Korean

The "Powered by" text is still in English within the Korean locale file. Consider translating it to Korean for consistency.

Suggested translation (to be verified by a Korean speaker):

-  "common_poweredBy": "Powered by <a>{{domain}}</a>",
+  "common_poweredBy": "<a>{{domain}}</a> 제공",

Committable suggestion skipped: line range outside the PR's diff.

"common_disableNotifications": "업데이트 수신을 중단하고 싶으시면 <a>알림을 끄셔도 됩니다.</a>.",
Comment on lines +2 to +3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing translations in Thai (th) and Vietnamese (vi) locale files

The verification revealed that the translation strings common_poweredBy and common_disableNotifications are missing in:

  • packages/emails/locales/th/emails.json
  • packages/emails/locales/vi/emails.json

These keys need to be added to maintain consistency across all locale files.

🔗 Analysis chain

Verify translations across all locale files

Let's ensure these new strings are consistently added across all locale files.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for the presence and consistency of these new strings across all locale files

# Find all emails.json files in locale directories
fd emails.json packages/emails/locales -x echo "=== {} ===" \; cat {}

# Check if the new keys exist in all locale files
echo "\nChecking for missing keys..."
for locale_file in $(fd emails.json packages/emails/locales); do
  echo "Checking $locale_file"
  jq 'has("common_poweredBy") and has("common_disableNotifications")' "$locale_file"
done

Length of output: 9203

"newPoll_preview": "참여 링크를 공유하여 응답 수집을 시작하세요."
}