Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1471

Merged
merged 10 commits into from
Jan 3, 2025
14 changes: 14 additions & 0 deletions packages/emails/locales/ko/emails.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
{
"common_poweredBy": "Powered by <a>{{domain}}</a>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Text needs to be translated to Korean

The "Powered by" text is still in English within the Korean locale file. Consider translating it to Korean for consistency.

Suggested translation (to be verified by a Korean speaker):

-  "common_poweredBy": "Powered by <a>{{domain}}</a>",
+  "common_poweredBy": "<a>{{domain}}</a> 제공",

Committable suggestion skipped: line range outside the PR's diff.

"common_disableNotifications": "업데이트 수신을 중단하고 싶으시면 <a>알림을 끄셔도 됩니다.</a>.",
Comment on lines +2 to +3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing translations in Thai (th) and Vietnamese (vi) locale files

The verification revealed that the translation strings common_poweredBy and common_disableNotifications are missing in:

  • packages/emails/locales/th/emails.json
  • packages/emails/locales/vi/emails.json

These keys need to be added to maintain consistency across all locale files.

🔗 Analysis chain

Verify translations across all locale files

Let's ensure these new strings are consistently added across all locale files.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for the presence and consistency of these new strings across all locale files

# Find all emails.json files in locale directories
fd emails.json packages/emails/locales -x echo "=== {} ===" \; cat {}

# Check if the new keys exist in all locale files
echo "\nChecking for missing keys..."
for locale_file in $(fd emails.json packages/emails/locales); do
  echo "Checking $locale_file"
  jq 'has("common_poweredBy") and has("common_disableNotifications")' "$locale_file"
done

Length of output: 9203

"finalizeHost_content": "<b>{{title}}</b> 예약이 완료되었습니다",
"finalizeHost_preview": "최종 예약 날짜입니다! 참가자들에게 공지하고 캘린더 초대장을 보냈습니다.",
"finalizeHost_heading": "최종 예약 날짜!",
"finalizeHost_content2": "참가자들에게 공지하고 캘린더 초대장을 보냈습니다.",
"finalizeHost_button": "이벤트 보기",
"finalizeHost_subject": "{{title}}에 예약된 날짜",
"finalizeParticipant_content": "<b>{{hostName}}</b>는 다음 날짜에 <b>{{title}}</b>를 예약했습니다",
"finalizeParticipant_preview": "최종 예약 날짜!",
"finalizeParticipant_heading": "최종 예약 날짜!",
"finalizeParticipant_content2": "이 이벤트에 대한 캘린더 초대장을 첨부해 드렸습니다.",
"finalizeParticipant_subject": "{{title}}에 예약된 날짜",
"login_button": "{{domain}}에 로그인합니다",
Comment on lines +2 to +15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing translations in Thai (th) and Vietnamese (vi) locale files

The verification confirms that the following translations are missing in both Thai and Vietnamese locale files:

  • common_poweredBy
  • common_disableNotifications
  • finalizeHost_content
  • finalizeParticipant_content
  • login_button

Please add these translations to maintain consistency across all locales.

🔗 Analysis chain

Verify translations in all locale files

These new strings need to be added to all locale files to maintain consistency. Previous review identified missing translations in Thai (th) and Vietnamese (vi) locale files.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for missing translations in all locale files

# Find all locale files and check for the new keys
for locale_file in $(fd emails.json packages/emails/locales); do
  echo "=== Checking $locale_file ==="
  jq '
    def check_key($key):
      if has($key) then
        empty
      else
        $key
      end;
    [
      check_key("common_poweredBy"),
      check_key("common_disableNotifications"),
      check_key("finalizeHost_content"),
      check_key("finalizeParticipant_content"),
      check_key("login_button")
    ] | select(length > 0)
  ' "$locale_file"
done

Length of output: 15752

"newPoll_preview": "참여 링크를 공유하여 응답 수집을 시작하세요."
}