Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taiwan is a country, not province of China. #43

Open
babebbu opened this issue Aug 15, 2021 · 9 comments
Open

Taiwan is a country, not province of China. #43

babebbu opened this issue Aug 15, 2021 · 9 comments

Comments

@babebbu
Copy link

babebbu commented Aug 15, 2021

According to Wikipedia, Taiwan is not a province of China.

There are lines of code representing "Taiwan" as "Taiwan, Province of China" which is unacceptable. I've created some pull requests which updating those lines of code in /all folder (csv, json, xml).

@lukes
Copy link
Owner

lukes commented Aug 15, 2021

Hi @babebbu. Thanks for your issue. Please see #22 which I believe is the same concern.

@lukes
Copy link
Owner

lukes commented Sep 16, 2021

Hi @babebbu. I'd like to close this issue and your PRs #42, #41, #40 because that is how the data is https://en.wikipedia.org/wiki/ISO_3166-1#Naming_and_disputes. I'd feel bad closing this issue without your response first, though. I'll leave this issue open for another month and close if I don't hear back.

@Mashimaro7
Copy link

Mashimaro7 commented Nov 1, 2022

Taiwan is not "contested". Taiwan is simply not a part of China, China just claims it is. It never was a part of the PRC, It was actually a territory of Japan until the KMT fled there after WWII and established the current country Taiwan,(long story short, there was a big civil war up to, and after WWII, the KMT fought off the Japanese while the CCP hid in the hills, the CCP came out afterwards and drove the KMT out, forcing them to retreat to Taiwan AKA Republic of China... kinda like how the Koreas have similar names, Republic of China does NOT mean province of China). I've been to both China and Taiwan, I have a friend who lives in Taiwan and would consider myself well-versed in the geopolitical situation of Taiwan.

The CCP thinks it can bully Taiwan into reunifying, or rather "unifying" because Taiwan was never a part of China lol, and as I saw you pointed out in the other case, even the UN gets Taiwan's status wrong. China forces people to change maps and add "province of China" to Taiwan all the time...

I see the ISO is also inaccurate. I don't see why you can't just change it to "Taiwan" or at very least "Republic of China(Taiwan)" so as to indicate that it is not a province of China... Because it isn't

@babebbu
Copy link
Author

babebbu commented Nov 1, 2022

Taiwan is not "contested". Taiwan is simply not a part of China, China just claims it is. It never was a part of the PRC, It was actually a territory of Japan until the KMT fled there after WWII and established the current country Taiwan, AKA Republic of China(kinda like how the Koreas have similar names, Republic of China does NOT mean province of China). I've been to both China and Taiwan, I have a friend who lives in Taiwan.

The CCP thinks it can bully Taiwan into reunifying, or rather "unifying" because Taiwan was never a part of China lol, and as I saw you pointed out in the other case, even the UN gets Taiwan's status wrong.

I see the ISO is also inaccurate. I don't see why you can't just change it to "Taiwan" or at very least "Republic of China(Taiwan)" so as to indicate that it is not a province of China... Because it isn't

I support and agree on this post at all.

@BStrauss3
Copy link

BStrauss3 commented Nov 1, 2022 via email

@Mashimaro7
Copy link

I don't see why you can't remove the factually incorrect "Province" bit. It has Palestine labelled as the "State of Palestine" even though Palestine is less of a country than Taiwan. Not saying you should remove that one either, but... Imagine if you put "Palestine, Province of Israel" lol

The UN, much like the US and a majority of the world kinda flip flops on the whole Taiwan issue. They treat it as a separate country, trade with them, America and Japan even performs military drills with the ROC military,, but on paper they say it's just part of China because China would throw a hissy fit if they went out and acknowledged the reality.

@BStrauss3
Copy link

BStrauss3 commented Nov 1, 2022 via email

@Mashimaro7
Copy link

Then why not take every contested nation down unless you know 100% it's borders are correct? It's not like you have to correct every conflicted zone to reflect reality, Taiwan is a clear cut case. Palestine is much less clear cut, yet "State of Palestine" seems to indicate it's a sovereign nation whereas "province of China" is saying "No, you are not a free, independent nation, you are a part of China!"

"The beauty of open source is you can maintain your own fork and build it to you own tastes." Okay? So what's stopping you from changing it?

@lukes
Copy link
Owner

lukes commented Nov 2, 2022

@Mashimaro7 @babebbu Thanks for your engagement on this issue. Above #43 (comment) I linked to an issue that hopefully clarifies why the country name for Taiwan is the way it is. I'll copy the relevant comment from that issue #22 (comment) here now:

Thank you for your comment. Yes, indeed I'm aware of the controversy. I make no actual decision on the names in the data myself, the data is a pure reflection of the IOS-3166 standard.

I'm aware of a long-running discussion over the name.

From wikipedia:

The ISO 3166 directory of names of countries and territories registers Taiwan (TW) separately from and in addition to the People's Republic of China (CN), but lists Taiwan as "Taiwan, Province of China" based on the name used by the UN under PRC pressure. In ISO 3166-2:CN, Taiwan is also coded CN-71 under China, thus making Taiwan part of China in ISO 3166-1 and ISO 3166-2 categories.
https://en.wikipedia.org/wiki/Political_status_of_Taiwan

There's also a section on the ISO-3166 page https://en.wikipedia.org/wiki/ISO_3166-1#Naming_and_disputes that mentions the naming dispute.

I hope you understand what this data is intended to be (a reflection of ISO-3166 standard) and what it isn't intended to be (a comment about the status of any nation in the data source).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants