added support for format v2; new file Merkle.swift and some additiona… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsoneaday I started reviewing this PR and things look good; generally just copying the logic the JS library uses. I did some cleanup: https://github.com/lukereichold/arweave-swift/tree/add-formatv2 I asked on the Discord forums and clarified that we can safely drop support for v1 transactions, which should make things easier. As some changes were made to |
|
Hello @lukereichold any update on this PR? Seemed like you might be able to relatively easily merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi here's the item. Again a little rough.
Note some changes seem trivial, like optional types on the transaction fields, but decoding did not work without them so please test if you decide to remove them.