-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "documentAccess": "dynamic-page" to manifest #323
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 12610310411Details
💛 - Coveralls |
This looks very good. Thanks. 👍 Did you test it locally by building the app and running it in Figma? I am on vacation so I can't test it for another week. But if you can confirm that it works, we can merge it. You just have to be 💯 sure as we can't so easily revert it I think. I have no computer with me. |
hold on. I am setting this to draft. I did have an issue with resolving the variable names with modes (or in general set with aliases) due to the new *Async functions. It should be resolved now. I do not mind waiting until you run some tests too, just to maybe test with some more different figma files. Enjoy your vacation! |
// get collection name and modes | ||
const { variableCollectionId } = variable | ||
const { name: collection, modes } = collections[variableCollectionId] | ||
const variables = await Promise.all(localVariables?.filter((variable) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukasoppermann I am not a big fan of all those Promise.all
but I could not find a better solution.
What do you think?
Fixes #317
Two separate commits, one to address some leftover formatting, and one to address the improvement mentioned in #317.
Unit test have been add to to cover more code (github copilot to the rescue!)