code cleanup #276

mjechow · 2023-11-12T04:33:54Z

As mentioned in another PR, I started some code cleanup strictly after sonarQube rules. The PR reduces findings of ~800 to ~250.

src/main/java/xades4j/utils/TimeStampDigestInputImpl.java

luisgoncalves · 2023-11-13T17:05:49Z

Thanks for submitting this! I'll probably only have time to get to it later this week, but it's not forgotten.

mjechow · 2023-11-13T17:39:14Z

no problem, don't stress yourself.

src/test/java/xades4j/production/SignedDataObjectsProcessorTest.java

luisgoncalves

Great cleanup, thanks for this.

I added some comments of this that need to be changed before merging, as they could be changes in behavior. Also, I think it's better to handle the upgrade of Santuario separately.

src/main/java/xades4j/properties/CommitmentTypePropertyBase.java

src/main/java/xades4j/properties/SignatureTimeStampProperty.java

src/main/java/xades4j/properties/data/CommitmentTypeData.java

src/main/java/xades4j/properties/data/CustomPropertiesDataObjsStructureVerifier.java

src/main/java/xades4j/providers/impl/HttpTimeStampTokenProvider.java

src/main/java/xades4j/xml/bind/xades/ObjectFactory.java

src/main/java/xades4j/xml/marshalling/ToXmlCommitmentTypeConverter.java

src/main/java/xades4j/xml/unmarshalling/FromXmlBaseTimeStampConverter.java

src/main/java/xades4j/xml/unmarshalling/FromXmlCommitmentTypeConverter.java

src/test/java/xades4j/production/OtherSignerTests.java

This reverts commit 01cc710.

luisgoncalves · 2023-11-20T21:54:47Z

Thanks for the follow-up. LGTM 👍

mjechow added 5 commits November 12, 2023 02:28

bump guava and guice

1eec600

bump xmlsec

01cc710

code cleanup

423b454

replace unnecessary explicit type arguments with <>

1d194e9

resolve sonar findings

431a4b4

mjechow commented Nov 12, 2023

View reviewed changes

src/main/java/xades4j/utils/TimeStampDigestInputImpl.java Outdated Show resolved Hide resolved

mjechow commented Nov 13, 2023

View reviewed changes

src/test/java/xades4j/production/SignedDataObjectsProcessorTest.java Outdated Show resolved Hide resolved

mjechow added 6 commits November 13, 2023 21:26

remove Base64 class and use java.util instead

e6b55dd

optimize imports

73f475f

use lambdas in test classes

ed3faec

replace unnecessary explicit type arguments with <> in test classes

7ba8313

add types to raw parameters

6cefd4c

prevent CWE-208: Observable Timing Discrepancy

4b83a38

luisgoncalves requested changes Nov 17, 2023

View reviewed changes

mjechow added 3 commits November 19, 2023 00:24

resolve PR comments

d1442cf

Revert "bump xmlsec"

2cf1092

This reverts commit 01cc710.

resolve PR comments pt.2

210c1cc

luisgoncalves added this to the vNext milestone Nov 20, 2023

luisgoncalves approved these changes Nov 20, 2023

View reviewed changes

luisgoncalves merged commit ecc634c into luisgoncalves:master Nov 20, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

code cleanup #276

code cleanup #276

mjechow commented Nov 12, 2023 •

edited

Loading

luisgoncalves commented Nov 13, 2023

mjechow commented Nov 13, 2023

luisgoncalves left a comment

luisgoncalves commented Nov 20, 2023

code cleanup #276

code cleanup #276

Conversation

mjechow commented Nov 12, 2023 • edited Loading

luisgoncalves commented Nov 13, 2023

mjechow commented Nov 13, 2023

luisgoncalves left a comment

Choose a reason for hiding this comment

luisgoncalves commented Nov 20, 2023

mjechow commented Nov 12, 2023 •

edited

Loading