Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies because of several CVEs #274

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

mjechow
Copy link
Contributor

@mjechow mjechow commented Oct 24, 2023

No description provided.

@luisgoncalves
Copy link
Owner

Thanks for this!

Can you please rebase? I've update a missing CRL to fix tests.

Also tried building, javadocs and tests locally. Looks good.

@luisgoncalves luisgoncalves added this to the vNext milestone Oct 25, 2023
@mjechow
Copy link
Contributor Author

mjechow commented Oct 26, 2023

Thanks. I hope the bumps of dependencies like gpg-plugin work. I cannot test them.

Furthermore, I saw some remarks by SonarLint. I you don't mind, I will refactor some parts of code time by time. Is it planned to switch to JUnit5?

Also Guice 7.0.0 is released with a slightly different api. Time will come, when xades4j needs to be updated.

@mjechow
Copy link
Contributor Author

mjechow commented Oct 26, 2023

Again, I did't rebase but merge. Sorry. I am not used to the gitHub GUI. :-(

@luisgoncalves
Copy link
Owner

luisgoncalves commented Oct 27, 2023

Right, I'll test those when preparing another release.

Sure, feel free to submit PRs :) I'll attend to them as time allows. Most of the library was written 10+ years ago; the language evolved a lot since then.

Regarding Junit5, I actually started upgrading. I'll try to pick up on that again soon.

@luisgoncalves luisgoncalves merged commit 68ae21e into luisgoncalves:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants