Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 1.20.5 #391

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Update to 1.20.5 #391

merged 1 commit into from
Apr 23, 2024

Conversation

DrexHD
Copy link
Contributor

@DrexHD DrexHD commented Mar 8, 2024

This draft PR is intended to track the progress of updating this mod (fabric module) to 1.20.5

@DrexHD
Copy link
Contributor Author

DrexHD commented Apr 20, 2024

This has now been ported to 1.20.5-rc2 and is ready for review. No further changes are expected for 1.20.5!

This port passes DynamicRegistryManager.EMPTY to text serialization to avoid having to pass wrapper lookups around. The main usage in text serialization seems to be item hover events, which are not used by this mod!

@DrexHD DrexHD marked this pull request as ready for review April 20, 2024 00:04
@lucko lucko merged commit 8af5bc5 into lucko:master Apr 23, 2024
1 check passed
@lucko
Copy link
Owner

lucko commented Apr 23, 2024

Thanks for the PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrexHD @lucko