-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tent icon #331
Add tent icon #331
Conversation
MoltenCoffee
commented
May 17, 2021
•
edited
Loading
edited
name | about | labels |
---|---|---|
New icon | Add a new icon to the library | 🎨 <icon |
- Name of the icon : Campsite
- Tags (alternative names for this icon) (add them in tags.json) : tent
- What is the purpose of this icon? : Depicting holidays or outdoor activities. Can be used in maps as well.
- 100% scale preview :
- Have you considered alternative possibilities for its naming or design? : It's roughly based on #61 at feather, but I feel this one is slightly more recognizable as a tent.
@MoltenCoffee Nice icon, thanks for the contribution! Can you split up the path in separate shapes? If you need any help with that let me know! |
Sure, of course! Which parts would need to be separate paths? I quickly 'colored' the icon below for reference, I hope you're able to see it. I'd assume it would have to be split in the following paths:
|
Also, I named it "campsite" as that is how it is listed in #116, but I think "tent" with "campsite" as an alias is probably better. Do you agree? |
@MoltenCoffee Yeah For the splitting paths, I think we can split it up in 4 paths.
I think the change of the paths that have a different angle (pink and yellow) is not visible when seeing this icon on 100%. |
I've replaced all paths, and like you said the difference in angles are negligible when viewed around 24px and way beyond. I've also renamed it to 'tent'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!
LGTM
@ericfennis Once you merge this PR, can you update icon status in this issue as well #119 |
@mittalyashu Will do! |