Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tent icon #331

Merged
merged 3 commits into from
May 20, 2021
Merged

Add tent icon #331

merged 3 commits into from
May 20, 2021

Conversation

MoltenCoffee
Copy link
Contributor

@MoltenCoffee MoltenCoffee commented May 17, 2021

name about labels
New icon Add a new icon to the library 🎨 <icon
  • Name of the icon : Campsite
  • Tags (alternative names for this icon) (add them in tags.json) : tent
  • What is the purpose of this icon? : Depicting holidays or outdoor activities. Can be used in maps as well.
  • 100% scale preview : campsite
  • Have you considered alternative possibilities for its naming or design? : It's roughly based on #61 at feather, but I feel this one is slightly more recognizable as a tent.

@ericfennis
Copy link
Member

@MoltenCoffee Nice icon, thanks for the contribution!

Can you split up the path in separate shapes?
Because some design programs don't like combined/merged paths.

If you need any help with that let me know!

@MoltenCoffee
Copy link
Contributor Author

Sure, of course! Which parts would need to be separate paths? I quickly 'colored' the icon below for reference, I hope you're able to see it.

Untitled

I'd assume it would have to be split in the following paths:

  • red (ground)
  • both greens (outside of the tent)
  • blue and brown (the entrance)
  • pink and yellow (the rods at the top) (these are at a slightly different angle compared to the tent itself)

@MoltenCoffee
Copy link
Contributor Author

Also, I named it "campsite" as that is how it is listed in #116, but I think "tent" with "campsite" as an alias is probably better. Do you agree?

@ericfennis
Copy link
Member

@MoltenCoffee Yeah tent is perfect. We prefer naming as is what it shows than what it means. Because icon can multiple meanings.

For the splitting paths, I think we can split it up in 4 paths.

  1. red
  2. Brown
  3. Green#1 with extended line to pink
  4. Green feat: Add caret icons #2 with extended line to yellow

I think the change of the paths that have a different angle (pink and yellow) is not visible when seeing this icon on 100%.

@MoltenCoffee
Copy link
Contributor Author

I've replaced all paths, and like you said the difference in angles are negligible when viewed around 24px and way beyond. I've also renamed it to 'tent'.

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!
LGTM

@mittalyashu
Copy link
Member

@ericfennis Once you merge this PR, can you update icon status in this issue as well #119

@ericfennis
Copy link
Member

@mittalyashu Will do!

@ericfennis ericfennis merged commit 1c1b6c7 into lucide-icons:master May 20, 2021
@karsa-mistmere karsa-mistmere mentioned this pull request Jun 15, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants