Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added hospital #1952

Merged
merged 3 commits into from
Mar 11, 2024
Merged

feat(icons): added hospital #1952

merged 3 commits into from
Mar 11, 2024

Conversation

karsa-mistmere
Copy link
Member

@karsa-mistmere karsa-mistmere commented Mar 7, 2024

Completes feathericons/feather#1178

What is the purpose of this pull request?

  • New Icon

Description

Adds a hospital icon as per #119

Icon use case

  • hospital
  • emergency room
  • various medical institutes/buildings

Alternative icon designs

image

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • I've based them on the following Lucide icons: building-2

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Added or changed icons

icons/hospital.svg

Preview cohesion icons/chevron-right-square.svg
icons/hospital.svg
icons/more-vertical.svg
Preview stroke widths icons/hospital.svg
icons/hospital.svg
icons/hospital.svg
DPI Preview (24px) icons/hospital.svg
Icon X-rays icons/hospital.svg

@ericfennis
Copy link
Member

Hmm I maybe in for the third alternative design. To make it a bit less "enterpricey".

@karsa-mistmere
Copy link
Member Author

Hmm I maybe in for the third alternative design. To make it a bit less "enterpricey".

Hah, that's pretty much the sole reason I went with this design, since the more enterprise-ey it is, the less people will think of a church.

@jguddas
Copy link
Member

jguddas commented Mar 8, 2024

I think "enterpricey" is good.

@ericfennis
Copy link
Member

Cool, let's go with this one!

@ericfennis ericfennis merged commit 96da23c into main Mar 11, 2024
7 checks passed
@ericfennis ericfennis deleted the icon/hospital branch March 11, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants