-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging Bug Fixes and Updates #61
base: master
Are you sure you want to change the base?
Changes from 18 commits
e2435d2
935d85c
cf222dd
21238df
c3f47e2
9c1edb5
97dd605
4b22353
a36ffed
f44d5e7
e523e22
ffcf522
8eedca6
6ad5240
0fd1d85
c185927
1b01047
05b1368
f0909ee
31a7827
968a2bc
3ad90a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,6 +76,7 @@ ipch/ | |
*.ncb | ||
*.opensdf | ||
*.sdf | ||
*.VC.db | ||
*.cachefile | ||
|
||
# Visual Studio profiler | ||
|
@@ -210,4 +211,5 @@ FakesAssemblies/ | |
GeneratedArtifacts/ | ||
_Pvt_Extensions/ | ||
ModelManifest.xml | ||
/Master/NucleusCoop.VC.VC.opendb | ||
**/*.VC.VC.opendb | ||
**/*.VC.db | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Didn't you added that extension already around 3rd comment? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did, but while I was adding "*.VC.db" to the .gitignore file, I thought I should generalize both patterns, so that they would include any directory. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Extension" exclusion already handle that? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are right. I'll clean that up. |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "paths"?
Every file with that extension, bar none, should be skipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern "**/*.VC.VC.opendb" is the same as "*.VC.VC.opendb". To be honest, I didn't realize that, when I made the commit, but I knew that "**/*.VC.VC.opendb" meant anywhere, including the current directory.
Edit: Apparently you have to escape asterisks in GitHub comments.