Automatically profile newly spawned threads #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucamuscat
changed the title
lucamuscat
force-pushed
the
multithreaded-support
branch
from
4cb03bd to
f089062
Compare
This was referenced Dec 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #10.
The implementation makes use of a hack where
sys.settraceis (ab)used detect the start and end of the execution of threads. Since the pyinstrument profiler requires active profilers to be stopped in the same thread that started them, we needed to stop the profiler inside ofsys.settraceonce we have detected that the thread being profiled has finished executing its target.Hopefully, pyinstrument will natively support profiling multiple threads in the near future, allowing us to get rid of this
sys.settracehack. There seems to be an issue in pyinstrument's issue board tracking this feature, but the issue (and the repo itself) seems pretty inactive.