fix: Correctly canonicalize query param spaces #18
+45
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, along with lucacasonato/deno_s3#55, will fix lucacasonato/deno_s3#54.
URLSearchParams#toString()
canonicalizes spaces in keys or values to+
:Whereas AWS requires them to be percent-encoded. Per https://docs.aws.amazon.com/general/latest/gr/create-signed-request.html#create-canonical-request: