Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Country support and improvements #1

Merged
merged 7 commits into from
Apr 26, 2017
Merged

Country support and improvements #1

merged 7 commits into from
Apr 26, 2017

Conversation

lubc
Copy link
Owner

@lubc lubc commented Apr 26, 2017

This PR fixes the issue mercadolibre#10 and also adds some improvements.

All the changes:

  • Allows to set a country code in auth_url method
  • Removes config.yml file and declares all the constants in lib/constants.rb
  • Adds Rspec dependency, updates syntax in spec/meli_spec.rb and adds coverage for auth_url
  • Fixes indentation
  • Updates README.md

@lubc lubc merged commit 8c86f7f into master Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lubc