Move update info URL to new domain #15748
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server automatically redirects to the new name, so why not move it on the engine side too?
This seems like a natural checklist item for the renaming. Presumably the old domain was left in for 5.10's release, at an earlier stage of the renaming; but 5.11 does not need to do the same.
How to test
Backdate to 5.9.1, remove common.conf (or the relevant lines
update_last_known
) from your cache directory, and replace the setting in builtin/settingtypes.conf. It will still find there is an update.Alternatively, remove the last checked date from common.conf as in method 1, then use wireshark to verify the HTTP request goes through. I just didn't get wireshark working today.