Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move update info URL to new domain #15748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Montandalar
Copy link
Contributor

@Montandalar Montandalar commented Feb 3, 2025

The server automatically redirects to the new name, so why not move it on the engine side too?

This seems like a natural checklist item for the renaming. Presumably the old domain was left in for 5.10's release, at an earlier stage of the renaming; but 5.11 does not need to do the same.

How to test

Backdate to 5.9.1, remove common.conf (or the relevant lines update_last_known) from your cache directory, and replace the setting in builtin/settingtypes.conf. It will still find there is an update.

Alternatively, remove the last checked date from common.conf as in method 1, then use wireshark to verify the HTTP request goes through. I just didn't get wireshark working today.

The server automatically redirects to the new name, so why not
move it on the engine side too?
@Montandalar
Copy link
Contributor Author

Also, the release_info files published still direct the user to download from minetest.net, that should be changed on the server side.

@sfan5 sfan5 added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Feb 3, 2025
@sfan5 sfan5 added this to the 5.11.0 milestone Feb 3, 2025
@cx384
Copy link
Contributor

cx384 commented Feb 3, 2025

Can we please do this in one go.
At least for the whole www.minetest.net. subdomain.
So just execute this:

git ls-files | grep -v "\.ico$" | xargs sed -i "s/www\.minetest\.net/www\.luanti\.org/g"

(I'm not sure about the "MS Windows icon resource" file, so it's excluded, but everything else should be fine as far as I can tell.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants