Move EnumString to separate file and add enum_to_string #15714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only moves code and adds
enum_to_string
, so it should be easy to review.(As mentioned in one of my other PRs #15681)
c_types.h
now only containsLuaError
andStackUnroller
, and includes improved.(At first, I implemented a very fancy templated enum <-> string conversion handler to do as much as possible at compile time, but the improvement was questionable not really worth the change, so I kept our
EnumString
.)Note:
Only
es_HudBuiltinElement
does not useenum_to_string
, since it behaves a little different.es_ItemType
andes_TouchInteractionMode
are (currently) only needed inc_content.cpp
so I moved them there, IMO it's better than keeping them inc_types.h
.To do
Ready for Review.
How to test
I don't know.