-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no sq] Misc fixes #15661
[no sq] Misc fixes #15661
Conversation
I think Microsoft would have more elation if we ask the Copilot. I have done this and am very unsatisfied with the result: How to test the changes proposed in PR #15661:
If you have further questions or need additional guidance, feel free to ask! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the error handling with the code provided in #15652, modified to do 60 steps.
you cant see me after 60 steps
58 0.017416000366211
you cant see me after 60 steps
59 0.016967000439763
you cant see me after 60 steps
60 0.018226999789476
you cant see me after 60 steps
61 0.016819000244141
Works.
The other changes look good. Please assume 👍 after the minor comments are handled.
commit 1: 🤷♂️
commit 2: fixes #15658
commit 3: fixes #15652
commit 4: fixes #15584
To do
This PR is Ready for Review.
How to test
maybe ask ChatGPT, idk