Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no sq] Misc fixes #15661

Merged
merged 4 commits into from
Jan 12, 2025
Merged

[no sq] Misc fixes #15661

merged 4 commits into from
Jan 12, 2025

Conversation

sfan5
Copy link
Collaborator

@sfan5 sfan5 commented Jan 8, 2025

commit 1: 🤷‍♂️
commit 2: fixes #15658
commit 3: fixes #15652
commit 4: fixes #15584

To do

This PR is Ready for Review.

How to test

maybe ask ChatGPT, idk

@HybridDog
Copy link
Contributor

maybe ask ChatGPT, idk

I think Microsoft would have more elation if we ask the Copilot. I have done this and am very unsatisfied with the result:

How to test the changes proposed in PR #15661:

  1. Review the Pull Request Description:

    • The description mentions "maybe ask ChatGPT, idk" indicating there are no specific testing instructions provided by the author.
  2. Review the Changed Files:

    • The PR changes 17 files including doc/lua_api.md, irr/include/SMaterial.h, irr/include/SMaterialLayer.h, and several files in the src/client and src/content directories.
    • You can view the list of changed files here.
  3. Clone the Repository and Checkout the PR Branch:

    git clone https://github.com/minetest/minetest.git
    cd minetest
    git fetch origin pull/15661/head:pr-15661
    git checkout pr-15661
  4. Build and Test the Project:

    • Follow the project's build and test instructions, typically found in the README.md or CONTRIBUTING.md files.
    • Ensure you thoroughly test the areas affected by the changes.

If you have further questions or need additional guidance, feel free to ask!

Mizokuiam

This comment was marked as spam.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the error handling with the code provided in #15652, modified to do 60 steps.

you cant see me after 60 steps
58	0.017416000366211
you cant see me after 60 steps
59	0.016967000439763
you cant see me after 60 steps
60	0.018226999789476
you cant see me after 60 steps
61	0.016819000244141

Works.

The other changes look good. Please assume 👍 after the minor comments are handled.

src/map.h Outdated Show resolved Hide resolved
doc/lua_api.md Outdated Show resolved Hide resolved
@sfan5 sfan5 merged commit 903d13f into luanti-org:master Jan 12, 2025
16 checks passed
@sfan5 sfan5 deleted the unrelated1 branch January 12, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants